Skip to content

Conversation

@nidhal-labidi
Copy link
Contributor

@nidhal-labidi nidhal-labidi commented Jan 28, 2025

Checklist

Reviewer

  • I've checked out the code and tested it myself.

Changes

  • Refactor the code of the classes: FlottformFileInputHost and FlottformFileInputClient in a way that allows multiple use cases to be built on top of it.
  • Allow bidirectional exchange of files.

Signed-off-by: nidhal-labidi <nidhal.labidi@compose.us>
…formFileInputHost and FlottformFileInputClient

Signed-off-by: nidhal-labidi <nidhal.labidi@compose.us>
@nidhal-labidi nidhal-labidi changed the title Allo bidirectional exchange of files Allow bidirectional exchange of files Jan 28, 2025
@nidhal-labidi nidhal-labidi requested a review from Narigo January 28, 2025 17:16
…iles

Signed-off-by: nidhal-labidi <nidhal.labidi@compose.us>
@nidhal-labidi
Copy link
Contributor Author

Will be divided into 2 separate PRs:

  • feat/bidirectional-file-exchange --> feat/flottform-bidirectional-data-transfer: Contains changes for the FlottformFileInput classes only. It provides the changes necessary to send multiple files in both directions.

  • feat/bidirectional-file-exchange-example --> feat/bidirectional-file-exchange: Contains an example of how the bidirectional file transfer can work in practice.

@nidhal-labidi
Copy link
Contributor Author

Please refer to the previous comment and the following PRs to see how Flottform implemented the new API and dealt specifically with bidirectional file transfer:

  1. Update FlottformFileInput classes to allow bidirectional file transfer #123
  2. Bidirectional file exchange example #124
  3. Update File exchange demos to use the new UI #125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants