fix: poam local-defs show no errors on 404 #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: poam local-defs now are a put operation as opposed to a post Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aligns POAM local definitions with the backend behavior by switching the save operation to a PUT and treating missing local definitions (404) as an empty state instead of an error.
Changes:
- Updated
PlanOfActionAndMilestonesLocalDefinitionsViewto treat 404s as “no data” (empty/create state) and only show the header “Edit” button when local definitions exist. - Updated
LocalDefinitionsFormto always issue a PUT to the corrected singularplan-of-action-and-milestonesAPI endpoint. - Added unit tests for both the view and the form to cover loading, error/404 handling, empty state, button labels, form submission method, and form data cleanup.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/views/plan-of-actions-and-milestones/PlanOfActionAndMilestonesLocalDefinitionsView.vue |
Adjusts UI states and error handling so 404 responses are treated as an empty state with a “Create Local Definitions” button, and wires a computed error that suppresses 404s. |
src/views/__tests__/PlanOfActionAndMilestonesLocalDefinitionsView.spec.ts |
Adds tests verifying loading text, 404 behavior (no error, empty state plus create button), and data rendering when components are present. |
src/components/poam/LocalDefinitionsForm.vue |
Fixes the API path to the singular plan-of-action-and-milestones and simplifies submission logic to always use PUT with decamelizeKeys. |
src/components/__tests__/LocalDefinitionsForm.spec.ts |
Adds tests to assert the form always uses PUT (never POST), button labeling for create vs. update, and cleanup of empty components before submit; includes a (slightly weak) test intended to cover the corrected API URL. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: poam local-defs now are a put operation as opposed to a post