Skip to content

New form system#453

Open
jthrilly wants to merge 333 commits intov4from
new-form-system
Open

New form system#453
jthrilly wants to merge 333 commits intov4from
new-form-system

Conversation

@jthrilly
Copy link
Member

@jthrilly jthrilly commented Aug 12, 2025

This PR is a second attempt at a new form system to replace the old, redux-form, based approach.

  • <Form> component, supporting async onSubmit handler
  • <Field> component, which connects any standard or custom input to the form system. When rendered within <Form /> automatically handles registering/unregistering.
  • Supports nested field names
  • <FieldSet /> component, designed for grouping <Field /> components, and conditionally rendering them.
  • useForm, useField, and useFormValue hooks to enable clean composition patterns, and features such as conditional rendering
  • Validation using zod functions
  • Accessibility support with appropriate aria properties being added by custom hooks
  • useProtocolForm custom hook, which translates a protocol form definition to a renderable list of Field components.
  • Implementation of form field variants via cva beta 1.0.0
  • Make a plan for validation functions. Zod schemas are great, but what about localisation and compatibility with existing validation?

@vercel
Copy link

vercel bot commented Aug 12, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
fresco-sandbox Ready Ready Preview, Comment Feb 5, 2026 11:17am
fresco-storybook Ready Ready Preview, Comment Feb 5, 2026 11:17am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
barf Ignored Ignored Feb 5, 2026 11:17am

Request Review

@github-actions
Copy link

github-actions bot commented Feb 3, 2026

🎭 Playwright E2E Test Report

Tests failed. View the full report here:

👉 https://complexdatacollective.github.io/Fresco/pr-453/

Report details

@github-actions
Copy link

github-actions bot commented Feb 3, 2026

🎭 Playwright E2E Test Report

Tests failed. View the full report here:

👉 https://complexdatacollective.github.io/Fresco/pr-453/

Report details

Ensure activity table ordering is deterministic by using explicit,
sequential IDs for events (event-001, event-002, event-003). When
the ActivityFeed query sorts by "timestamp DESC, id DESC", the IDs
now reinforce the timestamp ordering as a secondary sort key.

This prevents visual snapshot flakiness if timestamps were ever equal
or if there's any edge case in the database ordering.
@github-actions
Copy link

github-actions bot commented Feb 3, 2026

🎭 Playwright E2E Test Report

Tests failed. View the full report here:

👉 https://complexdatacollective.github.io/Fresco/pr-453/

Report details

The baseline snapshot had incorrect activity table ordering. The events
should display in timestamp DESC order (newest first):
1. Participant Added
2. User Login
3. Protocol Installed

Updated baseline to match the corrected ordering.
@github-actions
Copy link

github-actions bot commented Feb 3, 2026

🎭 Playwright E2E Test Report

Tests failed. View the full report here:

👉 https://complexdatacollective.github.io/Fresco/pr-453/

Report details

@github-actions
Copy link

github-actions bot commented Feb 3, 2026

🎭 Playwright E2E Test Report

Tests failed. View the full report here:

👉 https://complexdatacollective.github.io/Fresco/pr-453/

Report details

Incorporates v4 fixes:
- Interface styling fixes
- Side panel encrypted fixes
- Preview protocol import data fix
- API key assets in preview mode, geospatial interface
- Dyad/tie strength census runtime errors fix
- Node styling fixes
- Allow external data attributes when adding nodes from panels
- Narrative interface fix
- Click handler and drag working together
@github-actions
Copy link

github-actions bot commented Feb 5, 2026

🎭 Playwright E2E Test Report

Tests failed. View the full report here:

👉 https://complexdatacollective.github.io/Fresco/pr-453/

Report details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant