Skip to content

Fix Clang-tidy #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vgvassilev merged 1 commit into from
Nov 17, 2025
Merged

Fix Clang-tidy #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 7 additions & 12 deletions .github/workflows/clang-tidy-review-post.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,26 +11,21 @@ permissions:
pull-requests: write

concurrency:
group: ${{ github.workflow }}-${{ github.event.workflow_run.pull_requests[0].number }}
group: ${{ github.workflow }}-${{ github.event.pull_request.number }}
cancel-in-progress: true

jobs:
post-comments:
# Only run if the triggering workflow was from a pull request
if: github.event.workflow_run.event == 'pull_request'
build:
runs-on: ubuntu-latest

steps:
- name: Post review comments
id: post-review
uses: ZedThree/clang-tidy-review/post@v0.21.0
with:
max_comments: 10

# Fail if there are any clang-tidy warnings
- name: Check for issues
if: steps.post-review.outputs.total_comments > 0
run: |
echo "::error::Found ${{ steps.post-review.outputs.total_comments }} clang-tidy issues"
exit 1

# If there are any comments, fail the check
- if: steps.post-review.outputs.total_comments > 0
run: exit 1