Skip to content

Conversation

@igor9silva
Copy link

As per the last merged PR (#50), it looks like the release job did run, but the specific pnpm publish step was skipped.

This repo uses go-semantic-release to compute the new version bump, which relies on the commit messages to decide between a patch, minor or major bump.

Likely due to the PR merge having squashed commits, sematic-release says "no new version" and we end up with no deployment.

This change forces it to always do at least a patch bump.

@Gregoor
Copy link
Collaborator

Gregoor commented Sep 17, 2025

thanks for looking into it and sorry for the late response. Does that mean it also bumps when we update docs or the demo?

@igor9silva
Copy link
Author

Hi @Gregoor, yes.

I personally don't see that as an issue. Completely fine to bump a patch version in the case of updated docs.

Otherwise we'll have to make sure all merged commits follow the semantic-release conventions.

Alternatively, I could do a check step on PRs to guarantee it follows the convention. This would block non-confirming PRs from being merged, which I'm not a big fan of, but it's your call.

Let me know if I should update this.

@Gregoor
Copy link
Collaborator

Gregoor commented Oct 2, 2025

Yeah for me that would be an issue, would not want to push empty updates onto our users. We already use husky to lint commits to follow semvar conventions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants