Fixes #183 CN municipality locality hierarchy#238
Open
joelpittet wants to merge 1 commit intocommerceguys:mainfrom
Open
Fixes #183 CN municipality locality hierarchy#238joelpittet wants to merge 1 commit intocommerceguys:mainfrom
joelpittet wants to merge 1 commit intocommerceguys:mainfrom
Conversation
- Restructure BJ/SH/TJ/CQ subdivisions so districts are dependent localities. - Adds Shanghai regression test.
Author
|
I tested this out and it solves some issues (the ones it targets) but I am getting similar errors for Not sure where to take it from here... any guidance from others in #183? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Full disclosure: I used an AI coding assistant to draft the changes proposed in the issue (including this summary).
Summary: Re-shaped CN municipality subdivisions to add a locality level (e.g., “Shanghai Shi”) with districts as dependent localities; added regression coverage for Shanghai and updated existing CN validator tests to match the new hierarchy.