Fix Accordion not reacting to checked changing#261
Merged
Conversation
sshane
force-pushed
the
fix-accordion-reactive
branch
from
f20cf93 to
629331d
Compare
Contributor
deployed preview: https://comma-web--pr261-38ft9hev.web.appWelcome! Make sure to:
|
adeebshihadeh
added a commit
that referenced
this pull request
Dec 3, 2025
This reverts commit 521ef71.
Collaborator
|
This completely broke accordions. How did this get merged? |
sshane
added a commit
that referenced
this pull request
Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #256 (comment)
Seems like you can't have a two way
checkedbinding, so need this