Migrate application from React to SolidJS #189
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! I’ve finished the migration from React to SolidJS. The main goal was to move over to Solid's fine-grained reactivity while keeping the exact same look and feel of the original app.
What’s changed:
State & Lifecycle: Switched out all the React hooks (useState, useEffect, useRef) for Solid signals and effects.
Reactivity Fixes: Refactored component props to follow Solid’s patterns—accessing them as props.value instead of destructuring them in the function signature to keep the reactive tracking alive.
JSX Audit: Cleaned up all the className attributes to class, fixed SVG attribute casing (like stroke-width), and replaced .map() loops with and for better performance.
Dependency Cleanup: Fixed a build issue with @commaai/qdl by manually compiling it with tsc, so the environment is stable for everyone now.
Tests: Updated the test suite to use @solidjs/testing-library. The main "renders without crashing" test is passing green.