Skip to content

Conversation

@varunsripad123
Copy link

Hey! I’ve finished the migration from React to SolidJS. The main goal was to move over to Solid's fine-grained reactivity while keeping the exact same look and feel of the original app.

What’s changed:

State & Lifecycle: Switched out all the React hooks (useState, useEffect, useRef) for Solid signals and effects.
Reactivity Fixes: Refactored component props to follow Solid’s patterns—accessing them as props.value instead of destructuring them in the function signature to keep the reactive tracking alive.
JSX Audit: Cleaned up all the className attributes to class, fixed SVG attribute casing (like stroke-width), and replaced .map() loops with and for better performance.
Dependency Cleanup: Fixed a build issue with @commaai/qdl by manually compiling it with tsc, so the environment is stable for everyone now.
Tests: Updated the test suite to use @solidjs/testing-library. The main "renders without crashing" test is passing green.

@adeebshihadeh
Copy link
Collaborator

This does not remotely address the bounty goals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants