Skip to content

Migration dart2 #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MathieuAuclair wants to merge 3 commits into from
Closed

Migration dart2 #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a6755ff
upgrade dependencies
MathieuAuclair Sep 5, 2018
2610525
update readme with dart2 tools
MathieuAuclair Sep 5, 2018
766746a
fix travis config
MathieuAuclair Sep 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ before_script:
- git clone https://github.com/flutter/flutter.git -b master --depth 1
- ./flutter/bin/flutter doctor
script:
- ./flutter/bin/flutter test --coverage
- ./flutter/bin/flutter packages pub run build_runner test
after_success:
- bash <(curl -s https://codecov.io/bash) -t $CODE_COV_TOKEN
cache:
Expand Down
10 changes: 10 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,16 @@ Note: If you're not part of the Comiko project on Firebase, you can either ask t

- Place it under `comiko-app/android/app`

## Dart 2

Take note that this repository is now set to use dart2 tools with flutter. Commands like pub build, pub test are no longer supported. Please use build runner now!

```
❯ flutter packages pub run build_runner test

```


### Debug firebase auth
Get your debug keystore fingerprint.
There's no password for debug keystore, just hit enter when asked.
Expand Down
23 changes: 15 additions & 8 deletions pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,23 +8,30 @@ dependencies:
flutter_redux: "^0.5.0"
path: "^1.4.2"
comiko_shared:
git: https://github.com/comiko-app/shared.git
path: ../comiko_dependencies/shared
Copy link
Collaborator

@Pacane Pacane Sep 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idéalement on garde les deps en .git

Copy link
Collaborator Author

@MathieuAuclair MathieuAuclair Sep 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On ne peut pas, git n'est pas supporté sur dart 2 étrangement

Copy link
Collaborator

@Pacane Pacane Sep 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol n'importe quoi, les deps git fonctionnent encore.

Copy link
Collaborator

@Pacane Pacane Sep 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

le problème est probablement plus que "shared" n'est pas encore OK pour dart 2.

Copy link
Collaborator Author

@MathieuAuclair MathieuAuclair Sep 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je vais checker, quel est ta version de sdk?

Copy link
Collaborator

@Pacane Pacane Sep 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2+

Copy link
Collaborator Author

@MathieuAuclair MathieuAuclair Sep 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moi je suis sur 2.1, je vais vérifier si le problème persiste

comiko_backend:
path: ../comiko_dependencies/backend
# https://github.com/comiko-app/backend.git
cloud_firestore: '^0.2.6'
font_awesome_flutter: '^6.0.0'
url_launcher: "^2.0.1"
cloud_firestore: '^0.7.4'
font_awesome_flutter: '^8.0.1'
url_launcher: "^3.0.3"
intl: "^0.15.2"
cached_network_image: "^0.3.0"
cached_network_image: "^0.4.2"
async_loader: '>=0.1.0 <0.2.0'
firebase_auth: '^0.4.5'
google_sign_in: "^2.1.0"
firebase_auth: '^0.5.19'
google_sign_in: "^3.0.5"
flutter_facebook_login: '>=1.0.3 <2.0.0'

dev_dependencies:
json_annotation: "^1.1.0"
build_runner: "^0.10.1+1"
build_test: "0.10.3+1"
flutter_test:
sdk: flutter

# git & path require json annotation 0.2.2
dependency_override:
json_annotation: "^1.1.0"

# For information on the generic Dart part of this file, see the
# following page: https://www.dartlang.org/tools/pub/pubspec

Expand Down