Improve handling of surprises in the migrations folder#38
Open
salomvary wants to merge 2 commits intocomeara:masterfrom
Open
Improve handling of surprises in the migrations folder#38salomvary wants to merge 2 commits intocomeara:masterfrom
salomvary wants to merge 2 commits intocomeara:masterfrom
Conversation
salomvary
commented
Dec 1, 2016
salomvary
commented
- Ignore hidden files
- Print an error message with the migration file path if parsing fails for some reason
As error handling of the cli consists of printing the message of exceptions populated to the main method, it is important to have useful messages on these exceptions. An example of such an exception is `Source.fromInputStream(resource).getLines()` choking on files that can not be parsed with text encoding (eg. binary swap files saved by Vim) with the following message: "Input length = 1". There is no way to tell what went wrong with which file. This change will turn that useless error into something like this: "Error parsing migration file migrations/.some-migration-file.cql.swp: Input length = 1" Still not perfect but much better than before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.