-
Notifications
You must be signed in to change notification settings - Fork 7
feat(staging): add staging config #276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
amoeba
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this out by running and getting:
$ DBC_USE_STAGING=1 go run ./cmd/dbc auth login
Opening https://auth-staging.columnar.tech/activate?user_code=GMBD-VKNH in your default web browser...
Authentication successful!
One nit and one question: Did we want setting DBC_USE_STAGING to also have dbc use the staging index for search/info/install? It doesn't appear to be from this PR. Happy to mark that as a follow-ons. At least auth works here.
| DefaultOauthURI = "dbc-cdn-private.columnar.tech" | ||
| DefaultOauthClientID = "eSKuasirO0gUnGuNURPagErV3TSSFhEK" | ||
| var ( | ||
| defaultOauthURI = "dbc-cdn-private.columnar.tech" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Can we make these defaultOauthURI values the actual URI and then we don't have to concatenate a string later on like this?
mustParseURL("https://" + auth.DefaultOauthURI())},Maybe there's a reason you had it separated out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the IsColumnarPrivateRegistry function compares against url.URL.Host which doesn't contain the scheme. We also compare the host elsewhere which doesn't include the scheme, so it made more sense for the DefaultOauthURI to only be the host and not include the scheme so that I wouldn't have to reconstruct (or deconstruct) to perform the comparisons elsewhere with parsed URL objects.
Did we want setting DBC_USE_STAGING to also have dbc use the staging index for search/info/install? It doesn't appear to be from this PR. Happy to mark that as a follow-ons. At least auth works here.
It does force dbc to use the dbc-cdn-private-staging url for search/info/install of the private drivers. This doesn't implement adding the /staging/ prefix to the urls for the public registry, you're correct there. I think that's up for discussion I guess. Since we aren't dealing with auth stuff through there (i.e. we don't need to point at other URLs) we can use the built-in cloudfront cdn staging configs if we ever need to change the actual deployment configs I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, makes sense. No need for a change here. I think later down the line we could think about how this env var interacts with our REGISTRY_URL override (or whatever it's called).
Adds an undocumented environment variable
DBC_USE_STAGINGthat when set to 1, true or TRUE will point dbc's default private URI todbc-cdn-private-staging.columnar.techinstead ofdbc-cdn-private.columnar.tech.