Skip to content

Conversation

@zeroshade
Copy link
Member

closes #262

@zeroshade zeroshade changed the title Install-local-pkg feat(install): allow install from local package Jan 21, 2026
Copy link
Member

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It installed the package to /home/lidavidm/.config/adbc/drivers/drivername_linux_amd64_v0.1.0.toml which isn't what I'd expect, is it possible to get the 'right' name from the package itself? I guess the info isn't there...

@zeroshade
Copy link
Member Author

Yea, I don't think the info is there, the only option I have is to use the base name of the file. Otherwise we'd need to enforce the name of the package for us to parse it out?

I guess I could just check if the filename matches that pattern?

@lidavidm
Copy link
Member

I think it should at least reject the package or maybe ask you to specify a name since the name as-is isn't usable by the driver manager.

@zeroshade
Copy link
Member Author

Why isn't the name usable by the driver manager? Do we mistake the extension and use the wrong code path?

That said, it should be easy enough to add a parameter to specify a name. I'll do that

@zeroshade
Copy link
Member Author

@lidavidm Can you try and test this again? My updates should address the comments / issues you had.

Copy link
Member

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lidavidm
Copy link
Member

That does seem to do it

@zeroshade zeroshade merged commit 4547635 into main Jan 25, 2026
10 checks passed
@zeroshade zeroshade deleted the install-local-pkg branch January 25, 2026 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Idea: dbc install from local archive

3 participants