-
Notifications
You must be signed in to change notification settings - Fork 7
feat(install): allow install from local package #265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
lidavidm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It installed the package to /home/lidavidm/.config/adbc/drivers/drivername_linux_amd64_v0.1.0.toml which isn't what I'd expect, is it possible to get the 'right' name from the package itself? I guess the info isn't there...
|
Yea, I don't think the info is there, the only option I have is to use the base name of the file. Otherwise we'd need to enforce the name of the package for us to parse it out? I guess I could just check if the filename matches that pattern? |
|
I think it should at least reject the package or maybe ask you to specify a name since the name as-is isn't usable by the driver manager. |
|
Why isn't the name usable by the driver manager? Do we mistake the extension and use the wrong code path? That said, it should be easy enough to add a parameter to specify a name. I'll do that |
|
@lidavidm Can you try and test this again? My updates should address the comments / issues you had. |
lidavidm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
That does seem to do it |
closes #262