Needs Triage #6
Open
Needs Triage #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Features!
Scan for SSH host keys, rather than ignoring them entirely.
Added git to dependencies.
Update github raw
run python in hardcore mode with sudo
Added support for vars/vaults.
Now configures environments and sorts playbook order.
Write system_role to group_vars/local.yml
Added downloading of reforge command, if present.
update docs (include taiga wiki/misc updates)
Updated permissions to avoid side-effects.
Add pre- and post- hooks for playbooks, closes #5.
forge now stores the exit codes of each playbook
write status to temp not to current working dir
renaming arguments to align with the names used in bootstrap.py
Enable the ability to import templates from playbooks.
…existing before trying to execute it.
Add skipping the role playbook with forge. Also check for a playbook existing before trying to execute it.
new version causing playbook errors
IO-849 pin ansible version
convert subprocess output bytes to a dict
Need to transform the tags fetched via awscli to a usable internal format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intended functionality can be salvaged, but the implementation requires significant rework.
import argparseis not kosher.self_provision()branch complexity is too high.get_dependencies()does surprising things now (downloads roles, but not playbooks).argsis sloppy.args.skip_*littered all over the place obscures function responsibility.args.skip_downloadcould be a single guard clause indownload_from_s3(), for instance.argparseshould only be imported iflen(sys.argv) > 1.