Improve TLS configuration options in helm chart#8
Open
ossko wants to merge 2 commits intocolonyos:mainfrom
Open
Improve TLS configuration options in helm chart#8ossko wants to merge 2 commits intocolonyos:mainfrom
ossko wants to merge 2 commits intocolonyos:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The helm chart contained references to the now defunct multi-backend implementation as well as the old COLONIES_SERVER_TLS environment variable resulting in errors when attempting to deploy it.
In order to resolve this I have made the following changes:
The default behavior is now that the ingress will have TLS enabled while the ColonyOS server will have it disabled which I assume is what most people will want when deploying on Kubernetes but please verify that this matches your original intent.