Conversation
tonyelhabr
reviewed
Jul 8, 2022
|
|
||
| bucket <- str_extract( | ||
| without_s3_prefix, | ||
| ".+?(?=/)" |
tonyelhabr
reviewed
Jul 8, 2022
| @@ -0,0 +1,346 @@ | |||
| #' @importFrom stringr str_extract | |||
| generate_s3_key_bucket_ext <- function(artifact_name, run_id = get_active_run_id(), client = mlflow_client()) { | |||
Contributor
There was a problem hiding this comment.
does _ext signify extension? maybe _info is better given the list that's returned
tonyelhabr
approved these changes
Jul 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aws.s3in favor ofpaws.storage@tonyelhabr now if you hypothetically had a 10GB CSV file in S3 with CF scores, you can slice and dice it. Unfortunately, I don't think S3 Select let's you
group byso I think you'd need to load the data into memory regardless :/Given the inability to group by and stuff, I may not merge this in. But leaving it here at least to come back to later in case the
pawsmigration seems like a particularly great idea one day.