Upgrade rubocop to version 1.23.0 #54
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.
What changed?
✳️ rubocop (~> 0.76 → ~> 1.23) · Repo · Changelog
Release Notes
1.23.0
Does any of this look wrong? Please let us know.
Commits
See the full diff on Github. The new version differs by 38 commits:
Cut 1.23Update ChangelogAdd new `Gemspec/RequireMFA` cop.Refactor shared gemspec matcher into a mixin.Merge pull request #10246 from koic/tweak_offense_range_for_layout_space_in_lambda_literalMerge pull request #10224 from grosser/grosser/paths[Fix #10220] Naming/FileName: make CheckDefinitionPathHierarchy roots configurableTweak offense range for `Layout/SpaceInLambdaLiteral`Add rubocop-graphql as a third-party extension in the docsAdd rubocop-graphql to suggested extensionsChange `AllowAdjacentOneLineDefs` config parameter of `Layout/EmptyLineBetweenDefs` to `true` by defaultAdded additional documentation to `Naming/FileName` for currently undocumented configurations.[Fix #10221] Update `Naming::FileName` to recognize `Struct`s as classes that satisfy the `ExpectMatchingDefinition` requirement.Use `expect_offense` syntax for spec/rubocop/cop/naming/file_name_spec.rb.[Fix #10230] Fix a false positive for `Lint/AmbiguousRange`[Fix #10241] Fix `last_column` value for `JSONFormatter`Tweak changelog format doc and add a project specTweak a broken indentation of the rubydoc.info docsMerge pull request #10238 from ghiculescu/patch-1Require MFA for gem pushes.Fix bad indenting in docsMerge pull request #10233 from hirasawayuki/fix_inherit_from_remote[Fix #10174] Fix inherit_from_remote should follow remote includes path starting with `./`Merge pull request #10205 from dvandersluis/issue/10202Make `Lint/NumberConversion` aware of `to_r`Merge pull request #10235 from tejasbubane/fix-10203[Fix #10203] Fix `Style/FormatStringToken` to respect `IgnoredMethods` with nested structuresFix an error for `Style/Documentation`Merge pull request #10229 from koic/fix_a_false_positive_for_style_string_literals[Fix #10202] Add new `Lint/Ruby2Keywords` cop.Merge pull request #10217 from mttkay/mk-avoid-openstructMerge pull request #10228 from koic/fix_false_positive_for_style_parentheses_around_conditionFix a false positive for `Style/StringLiterals`[Fix #10227] Fix a false positive for `Style/ParenthesesAroundCondition`[Fix #10206] Add Style/OpenStructUse CopBump RuboCop Performance to 1.12.0Tweak a message for `rake new_cop`Switch back the docs versionDepfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase.All Depfu comment commands