Upgrade rubocop to version 1.22.2 #52
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.
What changed?
✳️ rubocop (~> 0.76 → ~> 1.22) · Repo · Changelog
Release Notes
1.22.2
Does any of this look wrong? Please let us know.
Commits
See the full diff on Github. The new version differs by 33 commits:
Cut 1.22.2Update ChangelogSuppress warning: constant `Net::HTTPServerException` is deprecatedUpdated `Gemspec/RequiredRubyVersion` register an offense when set to blank values.[Fix #10200] Fix an error when inspecting a directory named `*`[Fix #10186] Explicit block arg is not counted for `Metrics/ParameterLists`Merge pull request #10193 from koic/fix_an_error_for_empty_lines_around_exception_handling_keywordsFix an error for `Layout/EmptyLinesAroundExceptionHandlingKeywords`Merge pull request #10187 from koic/fix_false_positive_for_lint_ambiguous_range[Fix #10185] Fix a false positive for `Lint/AmbiguousRange`Merge pull request #10183 from koic/ci_against_jruby_9_3CI against JRuby 9.3Merge pull request #10181 from koic/fix_an_error_for_style_select_by_regexp[Fix #10180] Fix an error for `Style/SelectByRegexp`Merge pull request #10176 from koic/unmark_autocorrect_false_from_security_json_loadMerge pull request #10177 from dvandersluis/issue/10172Add documentation about `rubocop-daemon`.Unmark `AutoCorrect: false` from `Security/JSONLoad`Merge pull request #10169 from dvandersluis/same-lineTweak spell checking GitHub Actions workflow nameMerge pull request #10171 from franzliedke/hash-transform-values-leftover-to_hStyle/HashTransform*: Fix incorrect auto-correction when inside block body[Fix #8101] Reformat `rake spec` output to amplify signal and reduce noise.Merge pull request #10149 from Drowze/bundler-gemcomment-frozenRefactor code that can use `same_line?`.Update `InternalAffairs/LocationLineEqualityComparison` to handle `node.loc.first_line`, `node.first_line` and `node.source_range.line`.Merge pull request #10168 from dvandersluis/issue/10165[Fix #10165] Fix `Layout/DotPosition` false positives when the selector and receiver are on the same line.Update `Util#same_line?` to be able to compare ranges.Merge pull request #10164 from dvandersluis/fix/changelog-specRemoved stray `puts` from changelog.rb.Merge pull request #10159 from koic/add_internal_affairs_location_line_equality_comparison_copSwitch back the docs versionDepfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase.All Depfu comment commands