Fix(gurobi_py): Correctly handle binary variables in MIP solve #884
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR fixes a bug in the gurobi_py solver interface where binary variables (LpBinary) were being incorrectly treated as general countinuos (GRB.CONTINUOUS) when solving an MIP problem (i.e., when self.mip is True).
Description of the Bug
Currently, the variable type logic is:
"""
varType = gp.GRB.CONTINUOUS
if var.cat == constants.LpInteger and self.mip:
varType = gp.GRB.INTEGER
"""
Proposed Change
This patch adds a subsequent if statement to ensure that LpBinary variables are correctly identified and set to GRB.BINARY
Change:
"""
varType = gp.GRB.CONTINUOUS
if var.cat == constants.LpInteger and self.mip:
varType = gp.GRB.INTEGER
if var.cat == constants.LpBinary and self.mip:
varType = gp.GRB.BINARY
"""