Enable override of download URLs and ./configure flags for deps #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solvingj
force-pushed
the
solvingj/add_url_config
branch
from
591ca82 to
3defeba
Compare
- Normalize c_configure_args functions - Add more extensive comments to root yml file for posterity
solvingj
force-pushed
the
solvingj/add_url_config
branch
from
3defeba to
dd3694a
Compare
This was referenced Feb 6, 2025
zsimic
reviewed
Feb 14, 2025
| @property | ||
| def url(self): | ||
| return f"https://ftp.osuosl.org/pub/blfs/conglomeration/db/db-{self.version}.tar.gz" | ||
| return self.cfg_url(self.version) or f"https://ftp.osuosl.org/pub/blfs/conglomeration/db/db-{self.version}.tar.gz" |
Contributor
There was a problem hiding this comment.
I like this, it's a nice step, we could configure all these urls in the default built-in config (user config naturally overrides it).
| if PPG.config.get_value("cpython-use-github"): | ||
| return f"https://github.com/python/cpython/archive/refs/tags/v{self.version}.tar.gz" | ||
|
|
||
| if cfg_url := self.cfg_url(self.version): |
Contributor
There was a problem hiding this comment.
We need py3.8+ for :=, we need to adapt python_requires to reflect this in setup.py, and remove the legacy tests, ie the test-eol: section from .github/workflows/tests.yml
Contributor
|
Thank you! This is a great addition! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ability to download dependencies from private server from public internet is a key enterprise feature:
fixes #7
The ability to override ./configure flags already existed for cpython, this extends it to the deps.
fixes #57
This was needed in our case to add
no-dsoflag to make openssl statically compile on linux-aarch64.