Improve closing hotspot tooltips #2332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tf
commented
Dec 9, 2025
tf
commented
- Close tooltips after clicking the link button
- Work around floating-ui issue that causes tooltips to close prematurely when trying to click a link preview tooltip of a tooltip link button
When clicking the link button in a hotspot tooltip, the tooltip now closes. This applies both to tooltips opened via hover and via click. Clicking elsewhere in the tooltip (e.g., selecting text) still keeps the tooltip open. In the editor, clicking the link preview tooltip (that shows the URL on hover) triggers the onClick callback, since clicking the link text itself is used for editing.
Prevent the tooltip from being activated again.
floating-ui appears to use native event handlers for detecting mousedown on the document, but React event callbacks for intercepting mousedown inside the floating element in the capture phase. Looks like capture phase for React events happens after native events in React 16. React 17 changes the event system here. This causes the first click on a link tooltip of the hotspot tooltip link button to close the tooltip before the link can be clicked in the editor. In the published editor it disables outside press dismissal once after a click inside the floating element. Disable capture for outside press to work around these issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.