Skip to content

fix(subscriptions): Prevent event creation limit bypass through deletion #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
codeunia-dev merged 1 commit into from
Nov 14, 2025
Merged

fix(subscriptions): Prevent event creation limit bypass through deletion #322

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions lib/services/subscription-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,12 +54,14 @@ class SubscriptionService {

const limits = SUBSCRIPTION_LIMITS[company.subscription_tier]

// Get events created this month
// Get events created this month (including deleted ones to prevent loophole)
// This counts ALL events created in the billing period, regardless of deletion status
const startOfMonth = new Date()
startOfMonth.setDate(1)
startOfMonth.setHours(0, 0, 0, 0)

const { count: eventsCount, error: eventsError } = await supabase
// First, try to count from events table (active events)
const { count: activeEventsCount, error: eventsError } = await supabase
.from('events')
.select('*', { count: 'exact', head: true })
.eq('company_id', companyId)
Expand All @@ -74,6 +76,18 @@ class SubscriptionService {
)
}

// Also count deleted events from audit log if it exists
// This prevents the loophole where users delete events to bypass limits
const { count: deletedEventsCount } = await supabase
.from('event_audit_log')
.select('*', { count: 'exact', head: true })
.eq('company_id', companyId)
.eq('action', 'created')
.gte('created_at', startOfMonth.toISOString())

// Use the audit log count if available (more accurate), otherwise use active count
const eventsCount = deletedEventsCount !== null ? deletedEventsCount : (activeEventsCount || 0)

// Get active team members
const { count: membersCount, error: membersError } = await supabase
.from('company_members')
Expand Down
Loading