feat: add basic smoketest functionality #113
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: siherrmann <25087590+siherrmann@users.noreply.github.com>
NautiluX
reviewed
Dec 19, 2025
| c.cmd.Flags().BoolVarP(&c.Opts.Quiet, "quiet", "q", false, "Suppress progress logging") | ||
| c.cmd.Flags().DurationVar(&c.Opts.Timeout, "timeout", defaultTimeout, "Timeout for the entire smoke test") | ||
| c.cmd.Flags().StringVar(&c.Opts.Profile, "profile", defaultProfile, "CI profile to use for landscape and pipeline") | ||
| c.cmd.Flags().StringVar(&c.Opts.Steps, "steps", "", "Comma-separated list of steps to run (createWorkspace,setEnvVar,createFiles,syncLandscape,startPipeline,deleteWorkspace). If empty, all steps including deleteWorkspace are run. If specified without deleteWorkspace, the workspace will be kept for manual inspection.") |
Member
There was a problem hiding this comment.
would it make sense to generate the list of possible values from the constants defined above somehow?
| for _, step := range steps { | ||
| switch step { | ||
| case stepCreateWorkspace: | ||
| if err = c.stepCreateWorkspace(ctx, teamID, planID, workspaceName, &workspaceID); err != nil { |
Member
There was a problem hiding this comment.
they all seem to implement the same interface, would it make sense to collect them in something like a map[TestStep]TestStepFunc and iterate here (could be helpful for automatically listing them in the help output too)?
|
|
||
| func (c *SmoketestCodesphereCmd) logf(format string, args ...interface{}) { | ||
| if !c.Opts.Quiet { | ||
| fmt.Printf(format, args...) |
Member
There was a problem hiding this comment.
didn't we want to move to log.... ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ClickUp: https://app.clickup.com/t/869au15v2