update: add role validity check, add tests for role validity check #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: siherrmann <25087590+siherrmann@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR adds role validation to the API key registration process, ensuring only valid roles (Admin, Dev, Ext) are accepted. The change improves input validation and prevents invalid roles from being registered.
- Added role validity check in the
Registermethod - Updated test suite to verify role validation behavior
- Updated dependency versions in NOTICE file
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| cli/cmd/register.go | Added role validation logic to check against allowed roles before registration |
| cli/cmd/register_test.go | Added test cases for valid and invalid role scenarios, updated default test role to "Admin" |
| NOTICE | Updated dependency versions for several packages |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…into check-roles
Signed-off-by: siherrmann <25087590+siherrmann@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ClickUp: https://app.clickup.com/t/869bc90pp