Skip to content

Comments

fix(api-test): fix spec error#51

Open
twohorse0311 wants to merge 20 commits intodevelopfrom
fix/spec_error
Open

fix(api-test): fix spec error#51
twohorse0311 wants to merge 20 commits intodevelopfrom
fix/spec_error

Conversation

@twohorse0311
Copy link

No description provided.

@twohorse0311 twohorse0311 changed the title fix(backend): make service layer generate survey correctly fix(api-test): fix spec error Nov 29, 2023
Copy link

@soumyaray soumyaray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good but just suggested on little comment!

require_relative '../helpers/spec_helper.rb'

JSON_FORMAT_COMMAND = 'rubocop --except Metrics -f j 2>&1'
JSON_FORMAT_COMMAND = 'rubocop -f j --except Metrics 2>&1'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you leave a comment above this line explaining what the flags do?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. -f j: This parameter specifies the output format as JSON. -f stands for format, and j represents JSON.

  2. --except Metrics: This parameter instructs rubocop to ignore all rules in the Metrics category. Metrics typically include rules related to code length, complexity, etc.

  3. 2>&1: This is a shell command used to redirect standard error (stderr) to standard output (stdout). This ensures that both errors and regular output are captured and processed.

Copy link

@soumyaray soumyaray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Please make sure that the public CodePraise API still deletes repos. You may pass in an option set to the worker informing it whether or not to delete the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants