Skip to content

Conversation

@Nexite
Copy link
Contributor

@Nexite Nexite commented Mar 17, 2023

title and slug properties now set in getstaticprops or getserverside props. prevents re-rendering the component every time (this stops duplicate requests for contributors in footer and increases performance).

Also moved moment-timezone out of _app, reduced first load js by about 50kB.

Switching to nextjs compatible links should make pages load faster and makes user experience much smoother!

@oohwooh oohwooh self-requested a review March 17, 2023 20:04
@oohwooh oohwooh self-assigned this Mar 17, 2023
Copy link
Member

@oohwooh oohwooh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good at initial glance. We still need to test CRUD form functionality before merge, and I am currently too tired to trust myself to test that adequately.

@Nexite
Copy link
Contributor Author

Nexite commented Mar 21, 2023

useTopo is a function you wrap your nextjs config with and it uses webpack to replace the normal topo links (including with as="a" for buttons and boxes) with nextjs compatible ones. this means that you do not have to do anything special to get the links to work, it just happens automagically!

@Nexite
Copy link
Contributor Author

Nexite commented Mar 21, 2023

looks good at initial glance. We still need to test CRUD form functionality before merge, and I am currently too tired to trust myself to test that adequately.

based on my testing everything seems like it works fine, I'm not super familiar with all of the forms though.

@Nexite Nexite marked this pull request as draft March 22, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants