use packages from callPackages and update example #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
extending beamPackages is a cleaner way to enforce a specific elixir version
Contributor
|
Wonderful. I think I can clean up lots of at-work code with that extend example! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I originally opened this to use port compiler from the passed in
beamPackagesset, but went a bit further and removedpkgscompletely. This does have a bit more maintenance overhead in ensuring the explicit list of packages is in the header.pkgsis not a reliable method of accessing the active package set though, and in cross compilation scenarios could be actively problematic.I also cleaned up the example a bit with my recommended use.