-
Notifications
You must be signed in to change notification settings - Fork 15
refactor: update to nx 22 #1196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
View your CI Pipeline Execution ↗ for commit 17ddc1e
☁️ Nx Cloud last updated this comment at |
@code-pushup/ci
@code-pushup/cli
@code-pushup/core
@code-pushup/create-cli
@code-pushup/nx-plugin
@code-pushup/models
@code-pushup/axe-plugin
@code-pushup/coverage-plugin
@code-pushup/eslint-plugin
@code-pushup/js-packages-plugin
@code-pushup/jsdocs-plugin
@code-pushup/lighthouse-plugin
@code-pushup/typescript-plugin
@code-pushup/utils
commit: |
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit a9eb834 with previous commit 4f51446. 🕵️ See full comparison in Code PushUp portal 🔍 🏷️ Categories👍 3 groups improved, 👎 2 groups regressed, 👍 9 audits improved, 👎 5 audits regressed, 13 audits changed without impacting score🗃️ Groups
29 other groups are unchanged. 🛡️ Audits
652 other audits are unchanged. |
Code PushUp🤨 Code PushUp report has both improvements and regressions – compared current commit a9eb834 with previous commit 4f51446. 💼 Project
|
| 🏷️ Category | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|
| Code coverage | 🟡 85 | 🟡 89 | |
| Documentation | 🟡 65 | 🟡 64 |
4 other categories are unchanged.
👍 1 group improved, 👎 1 group regressed, 👍 3 audits improved, 👎 1 audit regressed, 2 audits changed without impacting score
🗃️ Groups
| 🔌 Plugin | 🗃️ Group | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|---|
| Code coverage | Code coverage metrics | 🟡 85 | 🟡 89 | |
| JSDocs coverage | Documentation coverage | 🟡 65 | 🟡 64 |
13 other groups are unchanged.
🛡️ Audits
| 🔌 Plugin | 🛡️ Audit | 📏 Previous value | 📏 Current value | 🔄 Value change |
|---|---|---|---|---|
| JSDocs coverage | Variables coverage | 🟥 7 undocumented variables | 🟥 7 undocumented variables | |
| Code coverage | Function coverage | 🟩 90 % | 🟩 96.4 % | |
| Code coverage | Line coverage | 🟨 79.7 % | 🟨 84.8 % | |
| Code coverage | Branch coverage | 🟨 75.6 % | 🟨 76.3 % | |
| JSDocs coverage | Types coverage | 🟥 15 undocumented types | 🟥 14 undocumented types | |
| JSDocs coverage | Functions coverage | 🟥 20 undocumented functions | 🟥 19 undocumented functions |
442 other audits are unchanged.
💼 Project plugin-lighthouse
😟 Code PushUp report has regressed.
🕵️ See full comparison in Code PushUp portal 🔍
| 🏷️ Category | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|
| Code coverage | 🟢 99 | 🟢 99 |
5 other categories are unchanged.
👎 1 group regressed, 👎 1 audit regressed
🗃️ Groups
| 🔌 Plugin | 🗃️ Group | ⭐ Previous score | ⭐ Current score | 🔄 Score change |
|---|---|---|---|---|
| Code coverage | Code coverage metrics | 🟢 99 | 🟢 99 |
14 other groups are unchanged.
🛡️ Audits
| 🔌 Plugin | 🛡️ Audit | 📏 Previous value | 📏 Current value | 🔄 Value change |
|---|---|---|---|---|
| Code coverage | Branch coverage | 🟩 96.2 % | 🟩 96.2 % |
443 other audits are unchanged.
12 other projects are unchanged.
This PR includes:
nx migrate latestplugin-typescriptint-testupdates due to 2 errors less introduces by version update (errors are not in our source code but in node_modules)plugin-typescript-e2ee2e-testupdates due to 2 errors less introduces by version update (errors are not in our source code but in node_modules)createNodesV2innx-plugincreateNodesinnx-pluginas not present in Nx v22closes #1173