Closed
Conversation
Sets up Criterion.rs for benchmarking and adds an initial benchmark for the `parse_codeowners` function. Includes: - Criterion.rs dependency in `Cargo.toml`. - Benchmark configuration in `Cargo.toml`. - `benches/parser_bench.rs` with benchmarks for `parse_codeowners`, including parsing of various CODEOWNERS line formats. - A GitHub Actions workflow (`.github/workflows/benchmarks.yml`) to run `cargo bench` on pushes to main and upload the HTML report as an artifact. Note: I wrote the benchmarks but couldn't run them in the development environment due to a specific version requirement for Rust. The setup assumes a standard Rust environment where `cargo bench` can compile and execute the benchmarks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets up Criterion.rs for benchmarking and adds an initial benchmark for the
parse_codeownersfunction.Includes:
Cargo.toml.Cargo.toml.benches/parser_bench.rswith benchmarks forparse_codeowners, including parsing of various CODEOWNERS line formats..github/workflows/benchmarks.yml) to runcargo benchon pushes to main and upload the HTML report as an artifact.Note: I wrote the benchmarks but couldn't run them in the development environment due to a specific version requirement for Rust. The setup assumes a standard Rust environment where
cargo benchcan compile and execute the benchmarks.