-
Notifications
You must be signed in to change notification settings - Fork 41
Update NetSuite integration reference with payment details #1769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -183,7 +183,7 @@ When writing Suppliers to Oracle NetSuite: | |
|
|
||
| ## Transfers | ||
|
|
||
| ### Reading Transfers | ||
| ### Reading transfers | ||
|
|
||
| Transfers are mapped from the <a class="external" href="https://docs.oracle.com/en/cloud/saas/netsuite/ns-online-help/chapter_N1547981.html" target="_blank">transfers</a> and <a class="external" href="https://docs.oracle.com/en/cloud/saas/netsuite/ns-online-help/chapter_N1542225.html" target="_blank">deposits</a> objects in NetSuite. | ||
|
|
||
|
|
@@ -193,7 +193,7 @@ The Transfers data type doesn't support multiple lines. | |
|
|
||
| When reading NetSuite deposits as Transfers, only top-level tracking categories are read (the tracking categories associated with the _to_ account in NetSuite). Codat's accounting data model does not support Tracking categories at the line item level. | ||
|
|
||
| ### Writing Transfers | ||
| ### Writing transfers | ||
|
|
||
| Writing Transfers is only supported for NetSuite deposits, not NetSuite transfers. | ||
|
|
||
|
|
@@ -202,6 +202,10 @@ When making a deposit in NetSuite, users can enter payments on the **Deposits** | |
| - The `depositedRecordRefs` array in the Transfer must specify either `payments`, `directIncomes`, or `journalEntries`. | ||
| - All transactions in the `depositedRecordRefs` array must share the same currency. | ||
|
|
||
| ## Payments and credit note allocation | ||
|
|
||
| It's not possible to pay the full value of a NetSuite Invoice with a Credit Note using Codat. If you try to pay the entire value of an Invoice using a Credit Note, the write operation will fail and NetSuite will return the following error message: `...Value 0.0 outside of valid min/max range for field payment...` | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 📝 [vale] reported by reviewdog 🐶 |
||
|
|
||
| ## Field coverage for supported data types | ||
|
|
||
| Codat's data model supports a wide range of fields within each data type. | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 [vale] reported by reviewdog 🐶
[Google.Will] Avoid using 'will'.