Skip to content

Add response object to the return object#1

Open
pecord wants to merge 1 commit intocmoncrief:masterfrom
freightview:add-response-to-return
Open

Add response object to the return object#1
pecord wants to merge 1 commit intocmoncrief:masterfrom
freightview:add-response-to-return

Conversation

@pecord
Copy link

@pecord pecord commented Mar 23, 2016

I ran into situation where I needed the status code from the response object, but it is not currently being returned. This PR adds the response object to data so it can be accessed.

Also fixed some lint issues such as ending with trailing whitespace or a line being to long.

@pecord
Copy link
Author

pecord commented Mar 23, 2016

One reservation I have in making this change is since this project only wraps cheerio and request I felt like it should still use the request callback signature (err, res, body) and either add $ and data.values as params or just leave those two on the data object and add that to the callback params.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments