Add derived types to Suggestions #78
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Derived types declarations (similar to
IRichMessage) are missing onBaseSuggestion, breaking serialization. This is shown with a simple test ran against the currentmasterbranch:serializedwill then look as follows, missing thedescriptionfield andmediaobject:{ "action" : "reply", "label" : "Some label", "postbackdata" : "LABEL" }Couple extra notes:
Descriptionfield, though the summary says it only applies to Twitter which is now deprecatedEndTimeandStartTimeinCalendarOptionsfor those fields to be picked up during serialization