1191 migrate license #1193
Merged
1191 migrate license #1193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddey2
changed the base branch from
978-migrate-users
to
1187-migrate-collections
longshuicy
approved these changes
Aug 30, 2024
Member
longshuicy
left a comment
longshuicy
left a comment
There was a problem hiding this comment.
Tested the license part with below data and works.
dataset = {‘id’: ‘66d0decd8d5270901236f5ce’, ‘name’: ‘dt1’, ‘description’: ‘bjkdscb’, ‘created’: ‘Thu Aug 29 15:49:17 CDT 2024’, ‘thumbnail’: None, ‘authorId’: ‘66d0deac9601dfcb9adb1737’, ‘spaces’: [], ‘resource_type’: ‘dataset’, ‘license’: {‘license_type’: ‘license1’, ‘license_url’: ‘’, ‘license_text’: ‘All Rights Reserve’, ‘holders’: ‘Dipa Dey’, ‘ccAllowCommercial’: False, ‘ccAllowDerivative’: False, ‘ccRequireShareAlike’: False}}
longshuicy
added a commit
that referenced
this pull request
Sep 3, 2024
* match other branch * adding new collection metadata * str not float * getting collections for a dataset in v1, fixing metadata for collections * posts collection name and id * adding routes for getting collections * making a method like the one in v1 for self and ancestors. it will be easier to build a collection hierarchy from this * sample json for mdata * posts collection name and id * building the data for collections * something works now * matching with other branch * methods for migrating collections as metadata * need to post it as metadata * change name * adding the metadata for collections * adding context url and right endpoint * getting spaces as well as collections * change name * remaning method * created v2 license based on v1 license details (#1193) Co-authored-by: Chen Wang <cwang138@illinois.edu> * removing print statements * better error logging --------- Co-authored-by: Dipannita <ddey2@illinois.edu> Co-authored-by: Chen Wang <cwang138@illinois.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To test, please pull v1 PR
I have chosen the standard license ids based on logic defined in models/LicenseData.scala in v1.