NT: Update build process to use pyproject.toml #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paddycarey
reviewed
Sep 3, 2025
paddycarey
reviewed
Sep 3, 2025
paddycarey
reviewed
Sep 3, 2025
Comment on lines
+23
to
+25
| pip install \ | ||
| --index-url=https://dl.cloudsmith.io/public/cloudsmith/cloudsmith-mlflow-plugin/python/simple/ \ | ||
| mlflow-cloudsmith-plugin |
Member
There was a problem hiding this comment.
why cloudsmith > pypi? we publish all our other open source projects directly to the canonical repos
Member
Author
There was a problem hiding this comment.
I wanted to get this properly reviewed before publishing anything to PyPi - I will add the PyPi release at the very end
paddycarey
reviewed
Sep 3, 2025
paddycarey
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build system modernization:
pyproject.tomlfile to define build requirements, project metadata, dependencies, entry points, and development tools configuration, usingsetuptoolsandsetuptools-scmfor version management.setup.py,MANIFEST.in, andpytest.iniin favor of configuration inpyproject.toml. [1] [2] [3]CI/CD workflow updates:
ci.ymlandrelease.yml) to use the new build system, including installingbuildandsetuptools-scm, building packages withpython -m build, and deriving the version fromsetuptools_scminstead ofsetup.py. Also setfetch-depth: 0for proper versioning inrelease.yml. [1] [2] [3] [4]Documentation improvements:
README.md