no-ticket: update gitignore and remove force log #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies the logging behavior in the _progress function by removing a redundant log message that forced progress to 100% and consolidating the synchronization completion logging into a single, more informative message.
Key changes:
- Removed the conditional check for progress < 100% before logging completion
- Eliminated the "forcing progress to 100%" debug log message
- Updated the synchronization completion log to include the actual progress percentage
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
estebangarcia
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes a small change to the
_progressfunction inplugin/cloudsmith_repository.py, simplifying the logic for logging package synchronization progress. The change removes the conditional check for progress less than 100% and updates the log message to include the current progress percentage.