Skip to content

Conversation

@BartoszBlizniak
Copy link
Member

  • Cleanup inputs
  • Add repo badges

Copilot AI review requested due to automatic review settings December 19, 2025 12:26
@BartoszBlizniak BartoszBlizniak merged commit 8a98bd3 into master Dec 19, 2025
20 checks passed
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR cleans up the README.md file by restructuring the inputs documentation into clear tables and adding repository status badges. The changes improve readability and maintainability while removing decorative emoji characters from documentation sections.

  • Adds status badges for test status, GitHub Marketplace, Node.js version, license, and releases
  • Restructures inputs documentation from bullet points to organized tables with clear columns (Input, Description, Required, Default)
  • Removes emoji characters from documentation text throughout the file

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

## Support

If you have any questions or need further assistance, please open an issue on GitHub. We're here to help! 💬 Alternatively, you can contact us at [support.cloudsmith.com](https://support.cloudsmith.com/).
If you have any questions or need further assistance, please open an issue on GitHub. We're here to help! Alternatively, you can contact us at [support.cloudsmith.com](https://support.cloudsmith.com/).
Copy link

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Emojis were removed from most of the document but still remain on this line. For consistency with the rest of the cleanup, this scroll emoji should also be removed.

Copilot uses AI. Check for mistakes.
| `oidc-auth-only` | Only perform OIDC authentication without installing the CLI | No | `false` |
| `oidc-auth-retry` | Number of retry attempts for OIDC authentication (0-10), 5 seconds delay between retries | No | `3` |
| `oidc-audience` | Audience to request when retrieving the GitHub OIDC token. Use `https://github.com/<org-name>` for standard GitHub audience | No | `api://AzureADTokenExchange` |
| `pip-install` | Install the Cloudsmith CLI via pip | No | - |
Copy link

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default value for pip-install should be false (as specified in action.yml line 39) rather than -. This provides more clarity about the actual default behavior.

Copilot uses AI. Check for mistakes.
| `api-host` | API Host for Cloudsmith | No | - |
| `api-proxy` | API Proxy for Cloudsmith | No | - |
| `api-ssl-verify` | Verify SSL certificates for Cloudsmith API | No | - |
| `api-user-agent` | User Agent for Cloudsmith API | No | - |
Copy link

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing whitespace detected after the pipe character at the end of this line. This should be removed for consistency with the other table rows.

Suggested change
| `api-user-agent` | User Agent for Cloudsmith API | No | - |
| `api-user-agent` | User Agent for Cloudsmith API | No | - |

Copilot uses AI. Check for mistakes.
| `oidc-namespace` | Cloudsmith organisation/namespace for OIDC | No | - |
| `oidc-service-slug` | Cloudsmith service account slug for OIDC | No | - |
| `oidc-auth-only` | Only perform OIDC authentication without installing the CLI | No | `false` |
| `oidc-auth-retry` | Number of retry attempts for OIDC authentication (0-10), 5 seconds delay between retries | No | `3` |
Copy link

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README documentation for oidc-token-validate input is missing. This input is defined in action.yml (line 29-32) with a description "Validate the OIDC token after authentication" and a default value of 'true', but it's not documented in the README inputs table.

Suggested change
| `oidc-auth-retry` | Number of retry attempts for OIDC authentication (0-10), 5 seconds delay between retries | No | `3` |
| `oidc-auth-retry` | Number of retry attempts for OIDC authentication (0-10), 5 seconds delay between retries | No | `3` |
| `oidc-token-validate` | Validate the OIDC token after authentication | No | `true` |

Copilot uses AI. Check for mistakes.

| Input | Description | Required | Default |
|------------------------|-------------|----------|---------|
| `cli-version` | Specific version of the Cloudsmith CLI to install | No | Latest |
Copy link

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description for cli-version input is inconsistent between the README and action.yml. The action.yml states "A specific version of the Cloudsmith CLI is installed/used" while the README states "Specific version of the Cloudsmith CLI to install". The wording should be synchronized for clarity.

Suggested change
| `cli-version` | Specific version of the Cloudsmith CLI to install | No | Latest |
| `cli-version` | A specific version of the Cloudsmith CLI is installed/used | No | Latest |

Copilot uses AI. Check for mistakes.
| `oidc-auth-retry` | Number of retry attempts for OIDC authentication (0-10), 5 seconds delay between retries | No | `3` |
| `oidc-audience` | Audience to request when retrieving the GitHub OIDC token. Use `https://github.com/<org-name>` for standard GitHub audience | No | `api://AzureADTokenExchange` |
| `pip-install` | Install the Cloudsmith CLI via pip | No | - |
| `executable-path` | Path to the Cloudsmith CLI executable | No | `GITHUB_WORKSPACE/bin/` |
Copy link

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default value for executable-path is incorrect. According to the source code (src/download-cli.js line 10), the actual default is GITHUB_WORKSPACE/bin/cloudsmith, not GITHUB_WORKSPACE/bin/. The table should show the complete path including the cloudsmith filename.

Suggested change
| `executable-path` | Path to the Cloudsmith CLI executable | No | `GITHUB_WORKSPACE/bin/` |
| `executable-path` | Path to the Cloudsmith CLI executable | No | `GITHUB_WORKSPACE/bin/cloudsmith` |

Copilot uses AI. Check for mistakes.
|------------------------|-------------|----------|---------|
| `cli-version` | Specific version of the Cloudsmith CLI to install | No | Latest |
| `api-key` | API Key for Cloudsmith authentication | No | - |
| `oidc-namespace` | Cloudsmith organisation/namespace for OIDC | No | - |
Copy link

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The word "organisation" uses British spelling. According to the coding guidelines, Americanized spelling should be used, so this should be "organization".

Suggested change
| `oidc-namespace` | Cloudsmith organisation/namespace for OIDC | No | - |
| `oidc-namespace` | Cloudsmith organization/namespace for OIDC | No | - |

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants