test: fix acceptance tests on Apple Silicon Macs#450
Draft
test: fix acceptance tests on Apple Silicon Macs#450
Conversation
dc22931 to
077755f
Compare
maxmoehl
previously approved these changes
Jan 14, 2025
We observed sporadic compilation or bytecode issues on Apple Silicon Macs. According to golang/go#42774, the env variable `GODEBUG=asyncpreemptoff=1` works around the issue by disabling asynchronous preemption of goroutines. This might impact garbage collection performance, but restores the same level of reliability to locally running tests as when run in Docker on an Intel based Mac. The `GODEBUG=asyncpreemptoff=1` variable is set when creating the Docker container for running tests locally, and applies to all Go code, including `go vet`, for which we also observed sporadic issues.
077755f to
931208c
Compare
Member
|
❓ Can you show the commands you ran and the errors you got before hand? |
Contributor
Author
Command (directly on the Mac, with Docker for Mac installed): cd routing-release
scripts/test-in-docker.bashmostly it's lines ending in |
Contributor
Author
|
ok, so I reran it a couple of times now and occasionally still get the illegal instruction, even with the flag set. I will put it back to draft and check some more things. It is possible that the env variable is not having an effect in all places, or it just doesn't help. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We observed sporadic compilation or bytecode issues
on Apple Silicon Macs.
According to golang/go#42774,
the env variable
GODEBUG=asyncpreemptoff=1works aroundthe issue by disabling asynchronous preemption of
goroutines.
This might impact garbage collection performance, but restores
the same level of reliability to locally running tests as
when run in Docker on an Intel based Mac.
The
GODEBUG=asyncpreemptoff=1variable is set when creatingthe Docker container for running tests locally, and applies
to all Go code, including
go vet, for which we also observedsporadic issues.