Skip to content

Conversation

@ionphractal
Copy link

This PR is related to cloudfoundry/bosh-agent#337 but the logic resides in bosh-utils.

@rkoster
I would still need help with how to write the tests. What would need to be done?

Btw adding it to the bosh-agent would then just look like this? https://github.com/cloudfoundry/bosh-agent/compare/main...ionphractal:bosh-agent:337-nice-child-scripts?expand=1

@rkoster
Copy link
Contributor

rkoster commented Nov 27, 2025

Thanks for picking this back up. With regards to testing, given that all logic sits in an external library, it would be best to only add an integration test which would write out a bash script in a temporary file and execute it once without the flag and once with the flag. The bash script could echo its own nice level.

@beyhan beyhan requested review from a team, Alphasite and s4heid and removed request for a team November 27, 2025 15:57
@beyhan beyhan moved this from Inbox to Pending Review | Discussion in Foundational Infrastructure Working Group Nov 27, 2025
@rkoster rkoster moved this from Pending Review | Discussion to Waiting for Changes | Open for Contribution in Foundational Infrastructure Working Group Dec 4, 2025
@linux-foundation-easycla
Copy link

CLA Missing ID CLA Not Signed

Quiet bool

// Run command with a priority lower than the parent process
RunNicer bool
Copy link

@Alphasite Alphasite Dec 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there perhaps a better name for this field indicating what nicer means? From skimming the linked issue (and the comment!) but it would not be obvious to me from the method name here.

Maybe something like: “ReducePriority” or “SpawnWithLowerPriority” or something like that? I don’t have a great suggestion. I’m sure there’s a standard name for this thing but I can’t remember off the top of my head what it should be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Waiting for Changes | Open for Contribution

Development

Successfully merging this pull request may close these issues.

3 participants