This repository was archived by the owner on Jan 21, 2022. It is now read-only.
Enable fabric #69
Open
Enable fabric #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Hey nimakaviani! The commit authors and yourself have already signed the CLA. |
nimakaviani
force-pushed
the
enable-fabric
branch
2 times, most recently
from
44c4d7a to
24ca045
Compare
Contributor
Author
|
checks are passing. The PR uses Tags in service definitions to determine the type of the service. |
Contributor
Author
|
as part of verifying this PR, @jberkhahn will try and deploy a sample voting application on a CF cluster and verify the functionality of the app when using fabric as the backing blockchain. |
- read the type of service from the TAGS description of the service config. `ethereum` and `fabric` are the two types of service known to the service broker at the moment.
- stop the running broker process after each test - unifies setup for all the integration tests - set package dependencies back to the right versions
- log exit code for the deployer when running the pusher fails - also add log line to capture configuratin json that gets passed to pusher.js
swetharepakula
force-pushed
the
enable-fabric
branch
from
05e61e5 to
2f439e6
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.