(feat) generate wasm-bindgen wrappers for #[rpc] methods in impl …#721
Open
ilijaljubicic wants to merge 2 commits intocloudflare:mainfrom
Open
(feat) generate wasm-bindgen wrappers for #[rpc] methods in impl …#721ilijaljubicic wants to merge 2 commits intocloudflare:mainfrom
ilijaljubicic wants to merge 2 commits intocloudflare:mainfrom
Conversation
…blocks - Introduced #[rpc] attribute macro for impl blocks - Automatically generates: - #[wasm_bindgen] struct with `env: worker::Env` - #[wasm_bindgen(constructor)] `new(env: Env)` - #[wasm_bindgen(js_name = "__is_rpc__")] method for JS discovery - Replaces #[rpc] on methods with #[wasm_bindgen] - Requires unique method names across all RPC exports - Updated macro docs and runtime constraints - Enables using Env inside rpc methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improvements
env: worker::Envnew(env: Env)Allows using Env inside RPC methods. Open space for further improvements for the rpc functionality.
Related: #720
RPC methods can be exported using a custom
#[rpc]attribute macro.RPC methods must be defined inside an
implblock annotated with#[rpc], and individual methods must also be marked with#[rpc].When the macro is expanded, it generates:
#[wasm_bindgen]-annotated struct withenv: worker::Env#[wasm_bindgen(constructor)] pub fn new(env: Env)#[wasm_bindgen(js_name = "__is_rpc__")] fn is_rpc(&self) -> boolfor RPC auto-discovery#[rpc]converted into#[wasm_bindgen]-annotated exportsExample
Expands to:
Used in in rpc client workers: