Skip to content

[WIP] Fix Typescript implementation as path has to be normalised #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thibmeu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[WIP] Fix Typescript implementation as path has to be normalised #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions packages/http-message-sig/src/build.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,15 @@ export function getUrl(
const host = extractHeader(message, "host");
const protocol = message.protocol || "http";
const baseUrl = `${protocol}://${host}`;
return new URL(message.url, baseUrl);
const url = new URL(message.url, baseUrl);
url.pathname = decodeURIComponent(url.pathname);
return new URL(url.href);
}
if (!(message as RequestLike).url)
throw new Error(`${component} is only valid for requests`);
return new URL((message as RequestLike).url);
const url = new URL((message as RequestLike).url);
url.pathname = decodeURIComponent(url.pathname);
return new URL(url.href);
}

// see https://datatracker.ietf.org/doc/html/draft-ietf-httpbis-message-signatures-06#section-2.3
Expand Down
4 changes: 2 additions & 2 deletions packages/http-message-sig/test/build.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,11 +110,11 @@ describe("build", () => {
const result = extractComponent(
{
method: "POST",
url: "https://www.example.com/path?param=value",
url: "https://www.example.com/%7epath?param=value",
} as unknown as RequestLike,
"@path"
);
expect(result).to.equal("/path");
expect(result).to.equal("/~path");
});

it("correctly extracts the @query", () => {
Expand Down