Skip to content

refactor(hcl): extract array sorting into common helper function #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rotem-cloud merged 1 commit into from
Jan 23, 2026
Merged

refactor(hcl): extract array sorting into common helper function #126

rotem-cloud merged 1 commit into from
Jan 23, 2026

Conversation

@rotem-cloud
Copy link
Collaborator

@rotem-cloud rotem-cloud commented Jan 23, 2026

Changes:

  • Add SortStringArrayAttribute() to hcl/attributes.go with support for
    custom sort functions
  • Refactor turnstile_widget migration to use common helper
  • Refactor zero_trust_access_application migration to use common helper
  • Create sortOIDCScopes() helper for custom OIDC scope ordering

@rotem-cloud rotem-cloud self-assigned this Jan 23, 2026
@rotem-cloud rotem-cloud merged commit b5a26f9 into main Jan 23, 2026
9 checks passed
@rotem-cloud rotem-cloud deleted the cloudflare/add-SortStringArrayAttribute-function branch January 23, 2026 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgirouard mgirouard mgirouard approved these changes

@SirCortly SirCortly Awaiting requested review from SirCortly

@tamas-jozsa tamas-jozsa Awaiting requested review from tamas-jozsa

@ssicard ssicard Awaiting requested review from ssicard

@vaishakdinesh vaishakdinesh Awaiting requested review from vaishakdinesh

@musa-cf musa-cf Awaiting requested review from musa-cf

Assignees

@rotem-cloud rotem-cloud

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rotem-cloud @mgirouard