Cloudflare/turnstile widget migration #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oudflare/tf-migrate into cloudflare/turnstile_widget_migration
SirCortly
reviewed
Jan 22, 2026
| // The Cloudflare API returns domains in alphabetical order, and since v5 uses | ||
| // ListAttribute (ordered) instead of SetAttribute (unordered), we must sort | ||
| // domains in both config and state to prevent drift | ||
| if attr := body.GetAttribute("domains"); attr != nil { |
Collaborator
There was a problem hiding this comment.
This might be worth extracting into a helper function, something like SortListAttributeAlphabetically
Collaborator
Author
There was a problem hiding this comment.
i'm actually working on a pr for that now
SirCortly
approved these changes
Jan 22, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e2e tests output:
Summary:
Step 1: v4 terraform apply
Status: ✓ SUCCESS
Step 2: Migration (v4 → v5)
Status: ✓ SUCCESS
Step 3: v5 plan (before apply)
Status: ✓ No changes needed
Step 4: v5 terraform apply
Status: ✓ SUCCESS
Step 5: v5 plan (after apply)
Status: ✓ SUCCESS - Stable state achieved
Result: No changes detected