Fix XSS vulnerability in llm-chat-app-template #913
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a Cross-Site Scripting (XSS) vulnerability in the
llm-chat-app-templatewhere user-generated content from the AI chat responses was not properly sanitized before being inserted into the DOM.What was fixed:
.innerHTMLwithout sanitization, allowing potential execution of malicious scripts.innerHTMLwith.textContentfor user-generated content and implemented proper HTML escapingChanges:
public/chat.jsto use safe DOM manipulation methodssrc/index.tspackage.jsonandpackage-lock.jsonChecklist
-templatepackage.jsonis populated<!-- dash-content-start -->and<!-- dash-content-end -->to designate the Dash readme preview.gitignorefile existspackage.jsoncontains adeploycommandpackage.jsoncontainsprivate: trueand noversionfieldNote: This PR is a security fix for an existing template. All template metadata requirements were already satisfied. The changes focus solely on remediating the XSS vulnerability.