Skip to content

Conversation

@leonklingele
Copy link
Contributor

No description provided.

@HansVanEijsden
Copy link

HansVanEijsden commented Dec 25, 2018

Thanks for the patch!
Unfortunately it's broken again in Nginx 1.15.8:

patching file src/event/ngx_event_openssl.c
Hunk #1 succeeded at 1272 (offset 5 lines).
Hunk #2 succeeded at 2125 (offset 9 lines).
Hunk #3 succeeded at 2267 (offset 9 lines).
patching file src/event/ngx_event_openssl.h
Hunk #2 FAILED at 107.
Hunk #3 succeeded at 117 (offset 1 line).
1 out of 3 hunks FAILED -- saving rejects to file src/event/ngx_event_openssl.h.rej

Content of the src/event/ngx_event_openssl.h.rej file:

--- src/event/ngx_event_openssl.h
+++ src/event/ngx_event_openssl.h
@@ -107,6 +116,10 @@ struct ngx_ssl_connection_s {
     unsigned                    try_early_data:1;
     unsigned                    in_early:1;
     unsigned                    early_preread:1;
+
+    ngx_ssl_dyn_rec_t           dyn_rec;
+    ngx_msec_t                  dyn_rec_last_write;
+    ngx_uint_t                  dyn_rec_records_sent;
 };

@kn007
Copy link

kn007 commented Dec 25, 2018

You could using my patch:
https://github.com/kn007/patch/blob/master/nginx.patch

Or fix the patch by youself like this:
kn007/patch@dc32ad5

@HansVanEijsden
Copy link

@kn007 thank you very much. Didn't know it could be that easy. Great! 👍🏻

@kn007
Copy link

kn007 commented Dec 25, 2018

@HansVanEijsden No worries. :)

@leonklingele
Copy link
Contributor Author

I've opened #102 which was rebased on the latest 1.15.8 release.

@kevin25
Copy link

kevin25 commented May 28, 2019

Is there any patch for nginx 1.16?

@HansVanEijsden
Copy link

HansVanEijsden commented May 28, 2019

Is there any patch for nginx 1.16?

I use this patch with perfect results: https://raw.githubusercontent.com/kn007/patch/master/nginx.patch
Edit: as already mentioned above. Still working great, also on 1.17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants