Skip to content

make the ping URL configurable #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gabivlj merged 1 commit into from
Dec 15, 2025
Merged

make the ping URL configurable #132

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/lib/container.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,14 @@ export class Container<Env = unknown> extends DurableObject<Env> {
entrypoint: ContainerStartOptions['entrypoint'];
enableInternet: ContainerStartOptions['enableInternet'] = true;

// pingEndpoint is the host and path value that the class will use to send a request to the container and check if the
// instance is ready.
//
// The user does not have to implement this route by any means,
// but it's still useful if you want to control the path that
// the Container class uses to send HTTP requests to.
pingEndpoint: string = 'ping';

// =========================
// PUBLIC INTERFACE
// =========================
Expand Down Expand Up @@ -448,7 +456,7 @@ export class Container<Env = unknown> extends DurableObject<Env> {
for (let i = 0; i < tries; i++) {
try {
const combinedSignal = addTimeoutSignal(waitOptions.signal, PING_TIMEOUT_MS);
await tcpPort.fetch('http://ping', { signal: combinedSignal });
await tcpPort.fetch(`http://${this.pingEndpoint}`, { signal: combinedSignal });

// Successfully connected to this port
console.log(`Port ${port} is ready`);
Expand Down
Loading