-
Notifications
You must be signed in to change notification settings - Fork 11.7k
Fix screenshot endpoint example to use URL instead of HTML #27784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: production
Are you sure you want to change the base?
Conversation
The example-screenshot-from-url.mdx partial was incorrectly using the 'html' parameter instead of 'url' parameter since its creation. This fixes the example to properly demonstrate taking a screenshot from a URL as the section title indicates.
|
This PR requires additional review attention because it affects the following areas: PartialsThis PR updates partial files, which are pieces of content used across multiple files in our Render component.
|
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
|
Preview URL: https://28811002.preview.developers.cloudflare.com |
- Add 'Concurrent browsers and pricing' subsection explaining 10 included, 30 max - Create 'Rate limits and errors' section with 'Understanding rate limits' subsection - Consolidate rate limit explanation with clear table showing per-second fill rates - Replace duplicate browser timeout notes with single footnote - Clarify upgrade path: Free users should upgrade first, then request higher limits - Remove duplicate DashButton from FAQ section
|
CI run failed: build logs |
Description
The
example-screenshot-from-url.mdxpartial file was incorrectly using thehtmlparameter instead of theurlparameter since its creation on September 15, 2025.This PR fixes the example under the "Take a screenshot from a URL" section to properly demonstrate taking a screenshot from a URL.
Changes
src/content/partials/browser-rendering/example-screenshot-from-url.mdxfrom usinghtml: 'Hello World!'tourl: 'https://workers.cloudflare.com/product/browser-rendering/'screenshotOptionsparameter to keep the example simple and focused on the URL usageInvestigation
Checked git history and confirmed this was wrong from the start - the file was never correct.