Don't add build/ to non-FIPS pre-built path + v4 compat alias#474
Merged
Don't add build/ to non-FIPS pre-built path + v4 compat alias#474
Conversation
kornelski
force-pushed
the
build-subdir
branch
from
5b900f2 to
eb1979a
Compare
kornelski
changed the title
cjpatton
approved these changes
Feb 17, 2026
| if config.is_bazel || (config.features.is_fips_like() && config.env.path.is_some()) { | ||
| &["lib"][..] | ||
| } else { | ||
| &["lib", "crypto", "ssl", ""][..] |
Collaborator
There was a problem hiding this comment.
Should this list include "lib"?
Collaborator
Author
There was a problem hiding this comment.
Yes. The script still recognizes BORING_BSSL_PATH that uses lib.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also adds
fips-precompiledas an alias for thefipsCargo feature. Thefipsflag in v4 is too annoying to deal with (either disablesset_compliance_policyor breaks the build due to missing hpke support).