Skip to content

fix: escape script vars #788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattzcarey merged 1 commit into from
Jan 17, 2026
+4 −2
Merged

fix: escape script vars #788

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion examples/mcp-client/src/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,9 @@ export class MyAgent extends Agent {
status: 200
});
} else {
const safeError = JSON.stringify(result.authError || "Unknown error");
return new Response(
`<script>alert('Authentication failed: ${result.authError}'); window.close();</script>`,
`<script>alert('Authentication failed: ' + ${safeError}); window.close();</script>`,
{
headers: { "content-type": "text/html" },
status: 200
Expand Down
3 changes: 2 additions & 1 deletion site/ai-playground/src/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,9 @@ export class Playground extends AIChatAgent<Env, PlaygroundState> {
status: 200
});
}
const safeError = JSON.stringify(result.authError || "Unknown error");
return new Response(
`<script>alert('Authentication failed: ${result.authError}'); window.close();</script>`,
`<script>alert('Authentication failed: ' + ${safeError}); window.close();</script>`,
{
headers: { "content-type": "text/html" },
status: 200
Expand Down
Loading