Skip to content

Comments

1.8.x#95

Open
Anshuraj17 wants to merge 4 commits intocloudband:1.8.xfrom
Anshuraj17:1.8.x
Open

1.8.x#95
Anshuraj17 wants to merge 4 commits intocloudband:1.8.xfrom
Anshuraj17:1.8.x

Conversation

@Anshuraj17
Copy link

No description provided.

*/
public class Attributes {

@Named("id")
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't need the @nAmed if the field have the same name as the params (please take a look on stack)

@cloudband
Copy link
Owner

Please squash the commits:
see from step 17 to step 22 (including)
http://blog.phymata.com/2013/01/25/an-annotated-github-workflow/

There should be 2 commits : 1. of the change 2. the version change

* @author deviyada
*
*/
public class Attributes extends Resource {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change the code style to be:
Tab size :3
Indent:3
Continuation indent:6

@cloudband
Copy link
Owner

Its looks much better great job!
general notes:

  1. Something in the Stack Resource is not aligned anymore ת I think it's because you're code style is not Tab size :3
    Indent:3
    Continuation indent:6
    2)Please run the maven checkstyle (it can for example help you find missing enters at the end of the file) mvn checkstyle:checkstyle
  2. Please add a resource with attribute to resource_type_list_response.json and run the moke mock test (question. all the resources have attribute? If not we need to add mock test for resource with attribute and without and to check that both of them are return correctly, If yes we need to change all the mock test to include attribute and test that the attribute is passed correctly)
    4)Please run the live and the mock tests
    5)please see comment on the squash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants