This repository was archived by the owner on Sep 19, 2019. It is now read-only.
Better handling of null doc ids #81
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A null doc id causes fabric to throw an erlang error, this needs to be caught and handled in all doc calls. It returns error not_found to agree with couchdb. BugzID: 17496
Contributor
There was a problem hiding this comment.
I prefer the 'NewRow = case Reason of' style rather than assigning a value in every branch, seems less surprising.
Contributor
Author
There was a problem hiding this comment.
actually I do too, and flymake complains about exported symbols, but as far as I know this is the preferred Cloudant approach.
Contributor
There was a problem hiding this comment.
I don't think so, but I'll wait for other commenters.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A null doc id causes fabric to throw an erlang error, this needs to be caught and handled in
all doc calls. It returns error not_found to agree with couchdb.
BugzID: 17496